alex-plekhanov commented on code in PR #10393:
URL: https://github.com/apache/ignite/pull/10393#discussion_r1108599529
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/transform/AbstractCacheObjectsTransformationTest.java:
##########
@@ -117,55 +116,27 @@ protected Ignite prepareCluster() throws Exception {
/**
*
*/
- protected void putAndCheck(Object val, boolean transformableVal, boolean
reversed) {
+ protected void putAndGet(Object val, boolean transformableVal, boolean
reversed) {
boolean binarizableVal = !(val instanceof String || val instanceof
Integer || val instanceof Object[] ||
val instanceof int[] || val instanceof Collection);
- boolean binarizableColVal = (val instanceof Object[] && !(val
instanceof String[] || val instanceof int[])) ||
- (val instanceof Collection &&
- !(F.first((Iterable<?>)val) instanceof String ||
F.first((Iterable<?>)val) instanceof Integer));
-
- boolean binaryVal = val instanceof BinaryObject;
-
- boolean binaryColVal = val instanceof BinaryObject[] ||
- (val instanceof Collection && F.first((Iterable<?>)val) instanceof
BinaryObject);
-
- if (binaryVal)
- assertTrue(binarizableVal);
-
- if (binaryColVal)
- assertTrue(binarizableColVal);
-
- assertFalse(binaryVal && binaryColVal);
- assertFalse(binarizableVal && binarizableColVal);
-
- Ignite node = backupNode(0, CACHE_NAME); // Any key, besause of single
partition.
-
- IgniteCache<Object, Object> cache = node.getOrCreateCache(CACHE_NAME);
-
Object k = reversed ? val : ++key;
Object v = reversed ? ++key : val;
- cache.put(k, v);
-
- checkPut(!reversed && binarizableVal, transformableVal);
-
- checkGet(
- k,
- v,
- !reversed && binaryVal,
- !reversed && binaryColVal,
- !reversed && binarizableVal,
- !reversed && binarizableColVal,
- transformableVal);
+ putWithCheck(k, v, !reversed && binarizableVal, transformableVal);
+ getWithCheck(k, v, transformableVal);
}
/**
*
*/
- private void checkPut(
- boolean binarizableVal,
- boolean transformableVal) {
+ private void putWithCheck(Object key, Object val, boolean binarizableVal,
boolean transformableVal) {
+ Ignite node = backupNode(0, CACHE_NAME); // Any key, besause of single
partition.
Review Comment:
besause -> because
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
