timoninmaxim commented on code in PR #10453:
URL: https://github.com/apache/ignite/pull/10453#discussion_r1109446143
##########
docs/_docs/thin-clients/java-thin-client.adoc:
##########
@@ -79,6 +79,10 @@ Note that the code above provides a failover mechanism in
case of server node fa
include::includes/partition-awareness.adoc[]
+Partition awareness functionality helps to avoid an additional network hop in
the following scenarios:
+1. Single-key operations API, like #put, #get, etc. However, the functionality
has no effect on those operations within explicit transactions (initiated via
ClientTransaction.txStart() described in <<Executed transactions>> section).
Review Comment:
I set up docs locally and link to "Executing Scan Queries" works, but links
on transactions and IndexQueries doesn't. Could you, please, check it?
##########
modules/core/src/main/java/org/apache/ignite/configuration/ClientConfiguration.java:
##########
@@ -525,6 +527,11 @@ public ClientConfiguration
setTransactionConfiguration(ClientTransactionConfigur
}
/**
+ * Used with single-key operations API, and it does not work for those
operations within explicit transactions
Review Comment:
You should also change docs here
##########
docs/_docs/thin-clients/java-thin-client.adoc:
##########
@@ -79,6 +79,10 @@ Note that the code above provides a failover mechanism in
case of server node fa
include::includes/partition-awareness.adoc[]
+Partition awareness functionality helps to avoid an additional network hop in
the following scenarios:
+1. Single-key operations API, like #put, #get, etc. However, the functionality
has no effect on those operations within explicit transactions (initiated via
ClientTransaction.txStart() described in <<Executed transactions>> section).
Review Comment:
"#put, #get" -> `put(), get()`
##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/JavaThinClient.java:
##########
@@ -359,6 +359,9 @@ void partitionAwareness() throws Exception {
try (IgniteClient client = Ignition.startClient(cfg)) {
ClientCache<Integer, String> cache = client.cache("myCache");
// Put, get or remove data from the cache...
+ cache.put(0; "Hello, world!");
Review Comment:
replace ';' with ','
##########
docs/_docs/thin-clients/java-thin-client.adoc:
##########
@@ -79,6 +79,10 @@ Note that the code above provides a failover mechanism in
case of server node fa
include::includes/partition-awareness.adoc[]
+Partition awareness functionality helps to avoid an additional network hop in
the following scenarios:
+1. Single-key operations API, like #put, #get, etc. However, the functionality
has no effect on those operations within explicit transactions (initiated via
ClientTransaction.txStart() described in <<Executed transactions>> section).
+2. ScanQuery and IndexQuery accept a partition number as a parameter with
which the query is routed to a particular server node that stores the requested
data. Refer to <<Executing Scan Queries>> and <<Executing Index Queries>>
sections for more information.
Review Comment:
Also, you should mark numerations correctly - to enforce every point starts
from new line. Currently, it is showed in a single line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
