[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #1721: IGNITE-18746 Sql. Sargs implementation alignment

[via GitHub]

AMashenkov commented on code in PR #1721:
URL: https://github.com/apache/ignite-3/pull/1721#discussion_r1121702498


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSecondaryIndexTest.java:
##########
@@ -920,4 +947,249 @@ public void testNullCondition3() {
                 .returns(7, null)
                 .check();
     }
+
+    @Test
+    public void testNullsInCorrNestedLoopJoinSearchRow() throws 
InterruptedException {
+        try {
+            sql("CREATE TABLE t(i0 INTEGER PRIMARY KEY, i1 INTEGER, i2 
INTEGER)");
+            sql("CREATE INDEX t_idx ON t(i1)");
+            // FIXME: https://issues.apache.org/jira/browse/IGNITE-18203
+            waitForIndex("t_idx");
+            sql("INSERT INTO t VALUES (1, 0, null), (2, 1, null), (3, 2, 2), 
(4, 3, null), (5, 4, null), (6, null, 5)");
+
+            List<RowCountingIndex> idxs = injectRowCountingIndex("T", "T_IDX");
+
+            String sql = "SELECT /*+ DISABLE_RULE('NestedLoopJoinConverter', 
'MergeJoinConverter') */ t1.i1, t2.i1 "
+                    + "FROM t t1 "
+                    + "LEFT JOIN t t2 ON t1.i2 = t2.i1";
+
+            assertQuery(sql)

Review Comment:
   ```suggestion
               assertQuery(sql)
                   .disableRules('NestedLoopJoinConverter', 
'MergeJoinConverter')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org