ibessonov commented on code in PR #1738: URL: https://github.com/apache/ignite-3/pull/1738#discussion_r1126165368
########## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/SslConfigurationValidatorImpl.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.configuration; + +import static org.apache.ignite.internal.util.StringUtils.nullOrBlank; + +import io.netty.handler.ssl.ClientAuth; +import java.nio.file.Files; +import java.nio.file.Path; +import org.apache.ignite.configuration.validation.ValidationContext; +import org.apache.ignite.configuration.validation.ValidationIssue; +import org.apache.ignite.configuration.validation.Validator; + +/** + * SSL configuration validator implementation. + */ +public class SslConfigurationValidatorImpl implements Validator<SslConfigurationValidator, SslView> { + + public static final SslConfigurationValidatorImpl INSTANCE = new SslConfigurationValidatorImpl(); + + @Override + public void validate(SslConfigurationValidator annotation, ValidationContext<SslView> ctx) { + SslView ssl = ctx.getNewValue(); + if (ssl.enabled()) { + validateKeyStore(ctx, ".keyStore", "Key store", ssl.keyStore()); + + ClientAuth clientAuth = ClientAuth.valueOf(ssl.clientAuth().toUpperCase()); Review Comment: I think it'll throw an exception if enum element is not found, is that the expected behavior? ########## modules/network/src/main/java/org/apache/ignite/internal/network/configuration/SslConfigurationValidatorImpl.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.configuration; + +import static org.apache.ignite.internal.util.StringUtils.nullOrBlank; + +import io.netty.handler.ssl.ClientAuth; +import java.nio.file.Files; +import java.nio.file.Path; +import org.apache.ignite.configuration.validation.ValidationContext; +import org.apache.ignite.configuration.validation.ValidationIssue; +import org.apache.ignite.configuration.validation.Validator; + +/** + * SSL configuration validator implementation. + */ +public class SslConfigurationValidatorImpl implements Validator<SslConfigurationValidator, SslView> { + + public static final SslConfigurationValidatorImpl INSTANCE = new SslConfigurationValidatorImpl(); Review Comment: I never understood, why do we need a static instance. I understand that you just replicated the approach, but nonetheless, I'm curious -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
