sanpwc commented on code in PR #1797:
URL: https://github.com/apache/ignite-3/pull/1797#discussion_r1141734325
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -1093,11 +1094,35 @@ CompletableFuture<Void>
saveDataNodesToMetaStorageOnScaleUp(int zoneId, long rev
return completedFuture(null);
}
- Map<String, Integer> dataNodesFromMetaStorage =
fromBytes(values.get(zoneDataNodesKey(zoneId)).value());
+ Entry dataNodesValue = values.get(zoneDataNodesKey(zoneId));
Review Comment:
What we expect to retrieve from the meta storage if there are no
corresponding keys?
We will get map with three elements, right?
The values will be null? or empty? See Entry#empty?
Is it possible to have null/empty dataNodesValue and non null/empty
zoneScaleUpChangeTriggerValue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
