tkalkirill commented on code in PR #1855:
URL: https://github.com/apache/ignite-3/pull/1855#discussion_r1151469795
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -673,15 +675,18 @@ private CompletableFuture<?>
updateAssignmentInternal(ConfigurationNotificationE
return failedFuture(e);
}
+ TableImpl table = tablesById.get(tblId);
+
+ // TODO: IGNITE-19082 Need another way to wait for indexes
+ table.addIndexesToWait(collectTableIndexes(tablesCfg.value(),
tblId));
Review Comment:
In `onUpdateAssignments`, we start creating a table, this is a convenient
entry point for adding indexes before recover raft groups.
Why not do it on table creation listeners?
**I'll try to answer:** Creating (each) indexes is an asynchronous operation
that can be performed later than we prepared to recover the raft groups and we
can skip the indexes at the beginning of the recovery of the raft group.
Before recovery raft groups, it is important for us to know the list of
indices that will be updated on recovery (in `PartitionListener`), now we are
waiting only for the PK index, and we forget about the rest, which is not
correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
