alievmirza commented on code in PR #1819:
URL: https://github.com/apache/ignite-3/pull/1819#discussion_r1155578260
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterManagementGroupManager.java:
##########
@@ -542,15 +549,15 @@ private void handleClusterState(ClusterStateMessage msg,
String senderConsistent
private CompletableFuture<CmgRaftService>
completeJoinIfTryingToRejoin(CmgRaftService cmgRaftService) {
if (attemptedCompleteJoinOnStart) {
- return cmgRaftService.completeJoinCluster()
+ return
cmgRaftService.completeJoinCluster(nodeAttributes.nodeAttributes().value())
.thenApply(unused -> cmgRaftService);
} else {
return completedFuture(cmgRaftService);
}
}
private CompletableFuture<CmgRaftService> joinCluster(CmgRaftService
service, ClusterTag clusterTag) {
- return service.startJoinCluster(clusterTag)
+ return service.startJoinCluster(clusterTag,
nodeAttributes.nodeAttributes().value())
Review Comment:
Discussed in private, that was made because we want to have only
`LogicalNode` in
`org.apache.ignite.internal.cluster.management.topology.LogicalTopology`, so we
have to pass this attributes for start as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
