sashapolo commented on code in PR #1899:
URL: https://github.com/apache/ignite-3/pull/1899#discussion_r1159404624
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/topology/api/LogicalNode.java:
##########
@@ -79,10 +78,9 @@ public Map<String, String> nodeAttributes() {
return nodeAttributes;
}
- /** {@inheritDoc} */
- @Override
- public String toString() {
- // TODO: S.toString for inherited classes do not work properly
https://issues.apache.org/jira/browse/IGNITE-19183
- return S.toString(LogicalNode.class, this);
- }
+ // TODO: S.toString for inherited classes do not work properly
https://issues.apache.org/jira/browse/IGNITE-19183
+ // @Override
+ // public String toString() {
+ // return S.toString(LogicalNode.class, this);
+ // }
Review Comment:
Please have a look at the ticket in the TODO above. Current implementation
simply prints `LogicalNode {}` hiding all important information, so I'd like to
use `toString` from `ClusterNode` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
