sashapolo commented on code in PR #1887:
URL: https://github.com/apache/ignite-3/pull/1887#discussion_r1159440908
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -483,21 +485,17 @@ public Collection<Entry> getAndPutAll(List<byte[]> keys,
List<byte[]> values) {
return res;
}
- /** {@inheritDoc} */
- @NotNull
@Override
public Entry get(byte[] key) {
rwLock.readLock().lock();
Review Comment:
This part was not written by me, but I believe that these locks are needed
to prevent removing of data during Meta Storage compaction (since we remove
data from two Column Families separately). Compaction is not used anywhere yet,
but I think this stuff should be re-worked altogether when we will implement
the GC mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
