tkalkirill commented on code in PR #1912:
URL: https://github.com/apache/ignite-3/pull/1912#discussion_r1161480196
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/RaftGroupService.java:
##########
@@ -76,26 +76,51 @@ public class RaftGroupService {
* @param nodeOptions Node options.
* @param rpcServer RPC server.
* @param nodeManager Node manager.
- * @param ownFsmCallerExecutorDisruptorConfig Configuration own striped
disruptor for FSMCaller service of raft node, {@code null}
- * means use shared disruptor.
*/
public RaftGroupService(
final String groupId,
final PeerId serverId,
final NodeOptions nodeOptions,
final RpcServer rpcServer,
- final NodeManager nodeManager,
- @Nullable RaftNodeDisruptorConfiguration
ownFsmCallerExecutorDisruptorConfig
+ final NodeManager nodeManager
) {
super();
this.groupId = groupId;
this.serverId = serverId;
this.nodeOptions = nodeOptions;
this.rpcServer = rpcServer;
this.nodeManager = nodeManager;
- this.ownFsmCallerExecutorDisruptorConfig =
ownFsmCallerExecutorDisruptorConfig;
+ this.ownFsmCallerExecutorDisruptorConfig = null;
}
+ /**
+ * @param groupId Group Id.
+ * @param serverId Server id.
+ * @param nodeOptions Node options.
+ * @param rpcServer RPC server.
+ * @param nodeManager Node manager.
+ * @param ownFsmCallerExecutorDisruptorConfig Configuration own
striped disruptor for FSMCaller service of raft node.
+ */
+ public RaftGroupService(
+ final String groupId,
+ final PeerId serverId,
+ final NodeOptions nodeOptions,
+ final RpcServer rpcServer,
+ final NodeManager nodeManager,
+ final RaftNodeDisruptorConfiguration
ownFsmCallerExecutorDisruptorConfig
+ ) {
+ super();
Review Comment:
Fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
