Flaugh24 commented on code in PR #1918:
URL: https://github.com/apache/ignite-3/pull/1918#discussion_r1161701875
##########
modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/TestServer.java:
##########
@@ -49,12 +52,15 @@ public class TestServer {
private final TestSslConfig testSslConfig;
+ private final AuthenticationConfiguration authenticationConfiguration;
+
private final ClientHandlerMetricSource metrics = new
ClientHandlerMetricSource();
private long idleTimeout = 5000;
- TestServer(@Nullable TestSslConfig testSslConfig) {
+ TestServer(@Nullable TestSslConfig testSslConfig,
AuthenticationConfiguration authenticationConfiguration) {
Review Comment:
Made
Here and in another TestServer, it is better to use the Builder pattern. But
I'd rather do it as a special ticket.
##########
modules/client-handler/src/integrationTest/java/org/apache/ignite/client/handler/TestServer.java:
##########
@@ -49,12 +52,15 @@ public class TestServer {
private final TestSslConfig testSslConfig;
+ private final AuthenticationConfiguration authenticationConfiguration;
+
private final ClientHandlerMetricSource metrics = new
ClientHandlerMetricSource();
private long idleTimeout = 5000;
- TestServer(@Nullable TestSslConfig testSslConfig) {
+ TestServer(@Nullable TestSslConfig testSslConfig,
AuthenticationConfiguration authenticationConfiguration) {
Review Comment:
Done
Here and in another TestServer, it is better to use the Builder pattern. But
I'd rather do it as a special ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
