xtern commented on code in PR #1917:
URL: https://github.com/apache/ignite-3/pull/1917#discussion_r1162425316
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -169,6 +169,10 @@ protected SqlSelect createSourceSelectForUpdate(SqlUpdate
call) {
final SqlIdentifier targetTable = (SqlIdentifier)
call.getTargetTable();
final SqlValidatorTable table =
getCatalogReader().getTable(targetTable.names);
+ if (table == null) {
+ throw newValidationError(call.getTargetTable(),
RESOURCE.objectNotFound(targetTable.toString()));
Review Comment:
> I see that it throws not SqlValidatorException and additional fix possibly
required,
Thanks, but I'm not fully understand your suggestion.
For example for select * from unknown calcite throws CalciteContextException
caused by.SqlValidatorException.
And the same behavior here:
```
CalciteContextException: From line 1, column 8 to line 1, column 14: Object
'UNKNOWN' not found
...
Caused by: org.apache.calcite.sql.validate.SqlValidatorException: Object
'UNKNOWN' not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
