ptupitsyn commented on code in PR #1927:
URL: https://github.com/apache/ignite-3/pull/1927#discussion_r1162593177
##########
modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/ClientColumnTypeConverter.java:
##########
@@ -24,12 +24,12 @@
*/
public class ClientColumnTypeConverter {
/**
- * Converts column type to wire code.
+ * Converts SQL column type to wire code.
*
* @param columnType Column type.
* @return Wire code.
*/
- public static int columnTypeToOrdinal(ColumnType columnType) {
+ public static int sqlColumnTypeToOrdinal(ColumnType columnType) {
Review Comment:
Yes, those are client protocol ordinals. But this code is not ideal, we have
too many different type codes. I think we even discussed the idea of replacing
all type codes with `ColumnType.ordinal` some time ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
