sergeyuttsel commented on code in PR #1729:
URL: https://github.com/apache/ignite-3/pull/1729#discussion_r1163728597


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -505,6 +543,148 @@ public int getZoneId(String name) {
         }
     }
 
+    /**
+     * The method for obtaining the data nodes of the specified zone.
+     * If {@link 
DistributionZoneConfigurationSchema#dataNodesAutoAdjustScaleUp} and
+     * {@link 
DistributionZoneConfigurationSchema#dataNodesAutoAdjustScaleDown} are immediate 
then it waits that the data nodes
+     * are up-to-date for the passed topology version.
+     *
+     * <p>If the values of auto adjust scale up and auto adjust scale down are 
zero, then on the cluster topology changes
+     * the data nodes for the zone should be updated immediately. Therefore, 
this method must return the data nodes which is calculated
+     * based on the topology with passed or greater version. Since the date 
nodes value is updated asynchronously, this method waits for
+     * the date nodes to be updated with new nodes in the topology if the 
value of auto adjust scale up is 0. And also waits for

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to