vldpyatkov commented on code in PR #1871:
URL: https://github.com/apache/ignite-3/pull/1871#discussion_r1165617606
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -181,22 +210,20 @@ public void run() {
HybridTimestamp now = clock.now();
- // Nothing holds the lease.
- if (lease == EMPTY_LEASE
- // The lease is near to expiration.
- || now.getPhysical() >
(lease.getLeaseExpirationTime().getPhysical() - LEASE_PERIOD / 2)) {
+ // The lease is expired or near to the one.
+ if (now.getPhysical() >
(lease.getExpirationTime().getPhysical() - LEASE_PERIOD / 2)) {
Review Comment:
I don't sure that clock skew is required here. Because here we are doing a
check proactive comparison, far a way from so little interval like a clock skew
is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
