tkalkirill commented on code in PR #1960:
URL: https://github.com/apache/ignite-3/pull/1960#discussion_r1172462608
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -725,8 +725,11 @@ private CompletableFuture<?>
updateAssignmentInternal(ConfigurationNotificationE
placementDriver.updateAssignment(replicaGrpId,
newConfiguration.peers().stream().map(Peer::consistentId).collect(toList()));
- PendingComparableValuesTracker<HybridTimestamp> safeTime = new
PendingComparableValuesTracker<>(new HybridTimestamp(1, 0));
- PendingComparableValuesTracker<Long> storageIndexTracker = new
PendingComparableValuesTracker<>(0L);
+ var safeTimeTracker = new PendingComparableValuesTracker<>(new
HybridTimestamp(1, 0));
+ var storageIndexTracker = new
PendingComparableValuesTracker<>(0L);
+
+ ((InternalTableImpl)
internalTbl).updatePartitionSafeTimeTracker(partId, safeTimeTracker);
Review Comment:
I follow the example with `RaftGroupService`, getting this is a "public" api
`org.apache.ignite.internal.table.InternalTable#partitionRaftGroupService`,
updating in the implementation
`org.apache.ignite.internal.table.distributed.storage.InternalTableImpl#updateInternalTableRaftGroupService`.
I think that for now let it remain as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
