xtern commented on code in PR #1880:
URL: https://github.com/apache/ignite-3/pull/1880#discussion_r1175056054
##########
modules/jdbc/src/main/java/org/apache/ignite/internal/jdbc/JdbcConnection.java:
##########
@@ -367,6 +374,20 @@ public void rollback(Savepoint savepoint) throws
SQLException {
throw new SQLFeatureNotSupportedException("Savepoints are not
supported.");
}
+ /**
+ * Finish transaction.
+ *
+ * @param commit {@code True} to commit, {@code false} to rollback.
+ * @throws SQLException If failed.
+ */
+ private void finishTx(boolean commit) throws SQLException {
+ JdbcFinishTxResult res = handler().finishTxAsync(connectionId,
commit).join();
Review Comment:
@AMashenkov Thanks, finally I did replace all `join()` to `get()`.
Since thread interruption is not described in any way by jdbc, then the user
should not use it, but it can really help us in development and testing.
The only note - at the moment I do not restore the thread interruption flag
when handling `InterruprionException`, please see the changes in the last two
commits, is that ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
