AMashenkov commented on code in PR #1939:
URL: https://github.com/apache/ignite-3/pull/1939#discussion_r1176214295
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/TypeUtils.java:
##########
@@ -89,6 +102,21 @@ public class TypeUtils {
SqlTypeName.INTERVAL_YEAR_MONTH
);
+ private Set<Class<?>> supportedParamClasses;
+
+ private static class LazyHolder {
+ static final TypeUtils INSTANCE = new TypeUtils();
+ }
+
+ private static TypeUtils instance() {
+ return LazyHolder.INSTANCE;
+ }
Review Comment:
```suggestion
private static class SupportedParamClassesHolder {
static final Set<Class<?>> supportedParamClasses;
private static {
supportedParamClasses =
Arrays.stream(ColumnType.values()).map(ColumnType::columnTypeToClass).collect(Collectors.toSet());
supportedParamClasses.add(boolean.class);
supportedParamClasses.add(byte.class);
supportedParamClasses.add(short.class);
supportedParamClasses.add(int.class);
supportedParamClasses.add(long.class);
supportedParamClasses.add(float.class);
supportedParamClasses.add(double.class);
supportedParamClasses.add(Character.class);
}
}
private static Set<Class<?>> supportedParamClasses() {
return SupportedParamClassesHolder.supportedParamClasses;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
