ibessonov commented on code in PR #1693:
URL: https://github.com/apache/ignite-3/pull/1693#discussion_r1182263634
##########
modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java:
##########
@@ -100,16 +150,14 @@ public long getPhysical() {
* @return The logical component.
*/
public int getLogical() {
- assert logical >= 0;
-
- return logical;
+ return (int) (time << PHYSICAL_TIME_BITS_SIZE >>>
PHYSICAL_TIME_BITS_SIZE);
Review Comment:
I don't know what I was thinking) I guess I wanted to reuse constants as
much as possible, because technically 0xFF_FF breaks encapsulation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
