AMashenkov commented on code in PR #2105: URL: https://github.com/apache/ignite-3/pull/2105#discussion_r1211521047
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/commands/altercolumn/AlterColumnAction.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.commands.altercolumn; + +import org.apache.ignite.internal.catalog.descriptors.TableColumnDescriptor; +import org.jetbrains.annotations.Nullable; + +/** + * Common interface for {@code ALTER COLUMN} column descriptor change actions. + */ +@FunctionalInterface +public interface AlterColumnAction { + /** + * Changes column descriptor. + * + * @param origin Column descriptor. + * @param isPkColumn {@code True} if this column is part of the primary key, {@code false} otherwise. + * @return Modified copy of the specified column descriptor, or {@code null} if no changes were made. + */ + @Nullable TableColumnDescriptor apply(TableColumnDescriptor origin, boolean isPkColumn); Review Comment: I don't like the boolean flag here. Why we can't have different implementation for PK columns and others? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
