isapego commented on code in PR #2149:
URL: https://github.com/apache/ignite-3/pull/2149#discussion_r1219749377
##########
modules/platforms/cpp/ignite/network/detail/win/sockets.cpp:
##########
@@ -82,10 +83,10 @@ void try_set_socket_options(SOCKET socket, int buf_size,
BOOL no_delay, BOOL out
int res = setsockopt(socket, SOL_SOCKET, SO_KEEPALIVE,
reinterpret_cast<char *>(&keep_alive), sizeof(keep_alive));
- // TODO: IGNITE-17606 Disable keep-alive once heartbeats are implemented.
+ // TODO: Disable keep-alive once heartbeats are implemented.
Review Comment:
Yeah, and the ticket was actually correct. Seems like I messed up something
here. Reverted changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
