tkalkirill commented on code in PR #2155:
URL: https://github.com/apache/ignite-3/pull/2155#discussion_r1221078830
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/util/MvPartitionStorages.java:
##########
@@ -238,14 +240,16 @@ public CompletableFuture<Void> startRebalance(int
partitionId, Function<T, Compl
assert old == null : createStorageInfo(partitionId);
return startRebalanceFuture;
- }).whenComplete((unused, throwable) ->
- operationByPartitionId.compute(partitionId, (partId,
operation) -> {
- assert operation instanceof
StartRebalanceStorageOperation :
- createStorageInfo(partitionId) + ", op=" +
operation;
+ }).whenComplete((unused, throwable) -> {
+ operationByPartitionId.compute(partitionId, (partId,
operation) -> {
+ assert operation instanceof
StartRebalanceStorageOperation : createStorageInfo(partitionId) + ", op=" +
operation;
- return completeOperation(operation);
- })
- );
+ return completeOperation(operation);
+ });
+
+ // Even if an error occurs, we must be able to abort the
rebalance, so we do not report the error.
Review Comment:
We don't need to handle an error on abort the rebalance, this error will be
thrown to the code that triggered the rebalance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
