SammyVimes commented on code in PR #2177:
URL: https://github.com/apache/ignite-3/pull/2177#discussion_r1230535548
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -682,14 +692,20 @@ private CompletableFuture<?> createTablePartitionsLocally(
int partitions = newAssignments.size();
CompletableFuture<?>[] futures = new CompletableFuture<?>[partitions];
+
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-19713 Process
assignments and set partitions only for assigned partitions.
+ PartitionSet parts = new BitSetPartitionSet();
+
for (int i = 0; i < futures.length; i++) {
futures[i] = new CompletableFuture<>();
+
+ parts.set(i);
}
String localMemberName = localNode().name();
// Create new raft nodes according to new assignments.
- Supplier<CompletableFuture<Void>> updateAssignmentsClosure = () -> {
+ Supplier<CompletableFuture<Void>> updateAssignmentsClosure = () -> {
Review Comment:
Good catch, good eye
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
