ascherbakoff commented on code in PR #2329:
URL: https://github.com/apache/ignite-3/pull/2329#discussion_r1279472218
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -233,10 +233,29 @@ private void handleUpdateCommand(UpdateCommand cmd, long
commandIndex, long comm
storageUpdateHandler.handleUpdate(cmd.txId(), cmd.rowUuid(),
cmd.tablePartitionId().asTablePartitionId(), cmd.rowBuffer(),
rowId -> {
- txsPendingRowIds.computeIfAbsent(cmd.txId(), entry -> new
TreeSet<>()).add(rowId);
+ if (!cmd.full()) {
+ txsPendingRowIds.computeIfAbsent(cmd.txId(), entry ->
new TreeSet<>()).add(rowId);
+ } else {
+ TxMeta txMetaToSet = new TxMeta(
+ COMMITED,
Review Comment:
Because one-phase tx is the same tx as others. For example, the primary
replica is updated, but replication command has failed. Such transaction
requires cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
