ptupitsyn commented on code in PR #2371:
URL: https://github.com/apache/ignite-3/pull/2371#discussion_r1280096406
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -385,6 +394,7 @@ private void writeError(long requestId, int opCode,
Throwable err, ChannelHandle
packer.packInt(ServerMessageType.RESPONSE);
packer.packLong(requestId);
writeFlags(packer, ctx);
+ packer.packLong(observableTimestamp(null));
Review Comment:
We should write `now()` with every error, because we don't know if an
operation has modified any data before it failed.
For example, a compute job can update one row and fail on another. As a
user, I would expect to see the first update from the client anyway, so we need
a recent timestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
