Flaugh24 commented on code in PR #2390: URL: https://github.com/apache/ignite-3/pull/2390#discussion_r1286696683
########## modules/file-transfer/src/main/java/org/apache/ignite/internal/network/file/FileTransferMessagesHandler.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.file; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import org.apache.ignite.internal.network.file.messages.FileChunkMessage; +import org.apache.ignite.internal.network.file.messages.FileHeaderMessage; +import org.apache.ignite.internal.network.file.messages.FileTransferInfoMessage; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.lang.IgniteInternalException; + +class FileTransferMessagesHandler { + private final Path dir; + private final AtomicInteger filesCount = new AtomicInteger(-1); + private final AtomicInteger filesFinished = new AtomicInteger(0); + private final CompletableFuture<List<File>> result = new CompletableFuture<>(); + private final Map<String, ChunkedFileWriter> fileNameToWriter = new ConcurrentHashMap<>(); + private final Map<String, Lock> fileNameToLock = new ConcurrentHashMap<>(); + + FileTransferMessagesHandler(Path dir) { + this.dir = dir; + } + + void handleFileTransferInfo(FileTransferInfoMessage info) { + if (result.isDone()) { + throw new IllegalStateException("Received file transfer info after result is already done."); + } + + filesCount.set(info.filesCount()); + + try { + completeIfAllFilesFinished(); + } catch (IOException e) { + handleFileTransferError(e); + } + } + + void handleFileHeader(FileHeaderMessage header) { + if (result.isDone()) { + throw new IllegalStateException("Received file header after result is already done."); + } + doInLock(header.fileName(), () -> handleFileHeader0(header)); Review Comment: No, it's called from `org.apache.ignite.internal.network.file.FileReceiver#executorService` ########## modules/file-transfer/src/main/java/org/apache/ignite/internal/network/file/FileTransferMessagesHandler.java: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.network.file; + +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.locks.Lock; +import java.util.concurrent.locks.ReentrantLock; +import java.util.stream.Collectors; +import java.util.stream.Stream; +import org.apache.ignite.internal.network.file.messages.FileChunkMessage; +import org.apache.ignite.internal.network.file.messages.FileHeaderMessage; +import org.apache.ignite.internal.network.file.messages.FileTransferInfoMessage; +import org.apache.ignite.internal.util.IgniteUtils; +import org.apache.ignite.lang.IgniteInternalException; + +class FileTransferMessagesHandler { + private final Path dir; + private final AtomicInteger filesCount = new AtomicInteger(-1); + private final AtomicInteger filesFinished = new AtomicInteger(0); + private final CompletableFuture<List<File>> result = new CompletableFuture<>(); + private final Map<String, ChunkedFileWriter> fileNameToWriter = new ConcurrentHashMap<>(); + private final Map<String, Lock> fileNameToLock = new ConcurrentHashMap<>(); + + FileTransferMessagesHandler(Path dir) { + this.dir = dir; + } + + void handleFileTransferInfo(FileTransferInfoMessage info) { + if (result.isDone()) { + throw new IllegalStateException("Received file transfer info after result is already done."); + } + + filesCount.set(info.filesCount()); + + try { + completeIfAllFilesFinished(); + } catch (IOException e) { + handleFileTransferError(e); + } + } + + void handleFileHeader(FileHeaderMessage header) { + if (result.isDone()) { + throw new IllegalStateException("Received file header after result is already done."); + } + doInLock(header.fileName(), () -> handleFileHeader0(header)); + } + + private void handleFileHeader0(FileHeaderMessage header) { + ChunkedFileWriter writer = fileNameToWriter.compute(header.fileName(), (k, v) -> { + if (v == null) { + return writer(header.fileName(), header.fileSize()); + } else { + v.fileSize(header.fileSize()); + return v; + } + }); + + try { + if (writer.isFinished()) { + writer.close(); + filesFinished.incrementAndGet(); + completeIfAllFilesFinished(); + } + } catch (IOException e) { + handleFileTransferError(e); + } + } + + void handleFileChunk(FileChunkMessage fileChunk) { + if (result.isDone()) { + throw new IllegalStateException("Received chunked file after result is already done."); + } + doInLock(fileChunk.fileName(), () -> handleFileChunk0(fileChunk)); Review Comment: No, it's called from `org.apache.ignite.internal.network.file.FileReceiver#executorService` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
