Cyrill commented on code in PR #2386:
URL: https://github.com/apache/ignite-3/pull/2386#discussion_r1288103617
##########
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/util/ConfigurationUtilTest.java:
##########
@@ -728,6 +774,84 @@ void testGetInternalConfigs() {
assertEquals("foo", subConfig.get("str02"));
}
+ @Test
+ void testGetPublicWithInternalConfigs() {
+ Map<Class<?>, Set<Class<?>>> extensions = schemaExtensions(List.of(
+ InternalFirstRootConfigurationSchema.class,
+ InternalSecondRootConfigurationSchema.class,
+ PublicRootConfigurationSchema.class,
+ InternalFirstConfigurationSchema.class,
+ InternalSecondConfigurationSchema.class,
+ PublicConfigurationSchema.class
+ ));
+
+ ConfigurationAsmGenerator generator = new ConfigurationAsmGenerator();
+ generator.compileRootSchema(InternalRootConfigurationSchema.class,
extensions, Map.of());
+
+ InnerNode innerNode =
generator.instantiateNode(InternalRootConfigurationSchema.class);
+
+ addDefaults(innerNode);
+
+ Map<String, Object> config = (Map<String, Object>) innerNode.accept(
+ null,
+ null,
+ ConverterToMapVisitor.builder()
+ .includeInternal(false)
+ .build()
+ );
+
+ // Check that public configuration will still be received.
+
+ assertEquals(5, config.size());
+ assertNull(config.get("str0"));
+ assertEquals("foo", config.get("str1"));
+ assertNotNull(config.get("subCfg"));
+ assertNotNull(config.get("namedCfg"));
+ assertNotNull(config.get("publicSubCfg1"));
+
+ Map<String, Object> subConfig = (Map<String, Object>)
config.get("subCfg");
+
+ assertEquals(2, subConfig.size());
+ assertEquals("foo", subConfig.get("str00"));
+ assertEquals("bar", subConfig.get("publicStr03"));
+
+ // Check that public configuration will be received along with the
internal one.
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
