[GitHub] [ignite-3] sanpwc commented on a diff in pull request #2475: IGNITE-19570 Write intent resolution for RW transactions

[via GitHub]

sanpwc commented on code in PR #2475:
URL: https://github.com/apache/ignite-3/pull/2475#discussion_r1302804202


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2382,18 +2422,18 @@ private CompletableFuture<Boolean> resolveTxState(
             UUID txId,
             HybridTimestamp timestamp
     ) {
-        requireNonNull(timestamp, "timestamp");
+        boolean readLatest = timestamp == null;
 
         return placementDriver.sendMetaRequest(commitGrpId, 
FACTORY.txStateReplicaRequest()
                         .groupId(commitGrpId)
-                        .readTimestampLong(timestamp.longValue())
+                        .readTimestampLong((readLatest ? 
HybridTimestamp.MIN_VALUE : timestamp).longValue())

Review Comment:
   It seems incorrect. Why we propagate MIN_VALUE as a read timestamp?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org