sanpwc commented on code in PR #2475:
URL: https://github.com/apache/ignite-3/pull/2475#discussion_r1303007885
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2382,18 +2422,18 @@ private CompletableFuture<Boolean> resolveTxState(
UUID txId,
HybridTimestamp timestamp
) {
- requireNonNull(timestamp, "timestamp");
+ boolean readLatest = timestamp == null;
return placementDriver.sendMetaRequest(commitGrpId,
FACTORY.txStateReplicaRequest()
.groupId(commitGrpId)
- .readTimestampLong(timestamp.longValue())
+ .readTimestampLong((readLatest ?
HybridTimestamp.MIN_VALUE : timestamp).longValue())
Review Comment:
Main point of timestamp propagation for RW is to have same and simple
approach for both RW and RO. We can't guarantee how this timestamp will be used
in future, maybe we will use it as an upper bound for txnState retrieval, or
who knows. Clock update seems fine because we also update clocks on all message
responses within RW protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
