ygerzhedovich commented on code in PR #2449:
URL: https://github.com/apache/ignite-3/pull/2449#discussion_r1303051257


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -518,6 +505,25 @@ public CompletableFuture<Void> closeAsync() {
         return stage;
     }
 
+    private static QueryTransactionWrapper beginImplicitTxIfNeeded(

Review Comment:
   I think such method should be part of QueryTransactionWrapper. And the 
QueryTransactionWrapper shouldn't have public constructors



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to