tkalkirill commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1313072617
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -245,37 +222,36 @@ public class TableManagerTest extends IgniteAbstractTest {
/** Hybrid clock. */
private final HybridClock clock = new HybridClockImpl();
+ /** Catalog vault. */
+ private VaultManager catalogVault;
Review Comment:
In the current test, the catalog has its own valt and metastore, the one
used in the test is mocked.
Then the question may arise, they say, why are they needed at all?
We need a `Consumer<LongFunction<CompletableFuture<?>>> registry` (for vv
entities inside **TableManager**) that used to be from the configuration, but
now it needs to be provided somehow. If there is a more elegant way to do this,
then welcome.
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -245,37 +222,36 @@ public class TableManagerTest extends IgniteAbstractTest {
/** Hybrid clock. */
private final HybridClock clock = new HybridClockImpl();
+ /** Catalog vault. */
+ private VaultManager catalogVault;
+
+ /** Catalog metastore. */
+ private MetaStorageManager catalogMetastore;
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
