tkalkirill commented on code in PR #2500:
URL: https://github.com/apache/ignite-3/pull/2500#discussion_r1319407949
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -245,37 +222,36 @@ public class TableManagerTest extends IgniteAbstractTest {
/** Hybrid clock. */
private final HybridClock clock = new HybridClockImpl();
+ /** Catalog vault. */
+ private VaultManager catalogVault;
Review Comment:
> I think you can pass a CatalogEvent directly to TableManager listeners.
I don’t understand how this can help, I need exactly:
`revisionUpdater = (LongFunction<CompletableFuture<?>> function) ->
catalogMetastore.registerRevisionUpdateListener(function::apply);`
> First of all, why do you guys need vault here? MS doesn't use it to store
key projections any longer. Seems that it's only used for persisting applied
revision which is also effectively deprecated.
I just want the tests to work when changing to a directory, then we can redo
that later.
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/TableManagerTest.java:
##########
@@ -245,37 +222,36 @@ public class TableManagerTest extends IgniteAbstractTest {
/** Hybrid clock. */
private final HybridClock clock = new HybridClockImpl();
+ /** Catalog vault. */
+ private VaultManager catalogVault;
Review Comment:
> I think you can pass a CatalogEvent directly to TableManager listeners.
I don’t understand how this can help, I need exactly:
`revisionUpdater = (LongFunction<CompletableFuture<?>> function) ->
catalogMetastore.registerRevisionUpdateListener(function::apply);`
> First of all, why do you guys need vault here? MS doesn't use it to store
key projections any longer. Seems that it's only used for persisting applied
revision which is also effectively deprecated.
I just want the tests to work when changing to a directory, then we can redo
that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
