AMashenkov commented on code in PR #2671:
URL: https://github.com/apache/ignite-3/pull/2671#discussion_r1354573377
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RowConverter.java:
##########
@@ -108,35 +108,20 @@ public static <RowT> BinaryTuple toBinaryTuple(
assert rowColumnsCount == binarySchema.elementCount() : "Invalid
lookup key.";
- if (IgniteUtils.assertionsEnabled()) {
- for (int i = 0; i < rowColumnsCount; i++) {
- if (handler.get(i, searchRow) ==
UNSPECIFIED_VALUE_PLACEHOLDER) {
- throw new AssertionError("Invalid lookup key.");
- }
- }
- }
-
BinaryTupleBuilder tupleBuilder = new
BinaryTupleBuilder(rowColumnsCount);
- return new BinaryTuple(rowColumnsCount, toByteBuffer(ectx,
binarySchema, handler, tupleBuilder, searchRow));
+ return new BinaryTuple(rowColumnsCount, toByteBuffer(binarySchema,
handler, tupleBuilder, searchRow, rowColumnsCount));
}
private static <RowT> ByteBuffer toByteBuffer(
- ExecutionContext<RowT> ectx,
BinaryTupleSchema binarySchema,
RowHandler<RowT> handler,
BinaryTupleBuilder tupleBuilder,
- RowT searchRow
+ RowT searchRow, int colCount
Review Comment:
```suggestion
RowT searchRow,
int colCount
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
