ygerzhedovich commented on code in PR #2678:
URL: https://github.com/apache/ignite-3/pull/2678#discussion_r1358108061


##########
modules/system-view/src/main/java/org/apache/ignite/internal/systemview/SystemViewManagerImpl.java:
##########
@@ -215,4 +236,44 @@ private void processNewTopology(LogicalTopologySnapshot 
topology) {
 
         this.owningNodesByViewName = Map.copyOf(owningNodesByViewName);
     }
+
+    private static Map<String, ScannableView<?>> toScannableViews(String 
localNodeName, Map<String, SystemView<?>> views) {
+        Map<String, ScannableView<?>> scannableViews = new HashMap<>();
+
+        for (SystemView<?> view : views.values()) {
+            scannableViews.put(view.name(), new ScannableView<>(localNodeName, 
(SystemView<Object>) view));
+        }
+
+        return Map.copyOf(scannableViews);
+    }
+
+    private static class ScannableView<T> {
+        private final BinaryTupleSchema schema;

Review Comment:
   what reason to have it as class field?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to