sashapolo commented on code in PR #2721:
URL: https://github.com/apache/ignite-3/pull/2721#discussion_r1365890190
##########
modules/core/src/main/java/org/apache/ignite/internal/Kludges.java:
##########
@@ -18,9 +18,9 @@
package org.apache.ignite.internal;
/**
- * Contains hacks needed for the whole codebase. Should be removed as quickly
as possible.
+ * Contains kludges needed for the whole codebase. Should be removed as
quickly as possible.
*/
-public class Hacks {
+public class Kludges {
Review Comment:
Why did you rename this?
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/schemasync/ItSchemaSyncSingleNodeTest.java:
##########
@@ -218,4 +223,49 @@ void
readWriteOperationInTxAfterAlteringSchemaOnAnotherTableIsUnaffected() {
assertDoesNotThrow(() -> putInTx(table, tx));
}
+
+ @ParameterizedTest
+ @EnumSource(Operation.class)
+ @Disabled("Enable after IGNITE-20680 is implemented")
Review Comment:
We usually simply use a JIRA link as the description
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -3178,25 +3229,28 @@ private static Boolean canReadFromWriteIntent(UUID
txId, @Nullable TransactionMe
return false;
}
- private CompletableFuture<Void> validateAtTimestamp(UUID txId) {
+ /**
+ * Takes current timestamp and makes schema related validations at this
timestamp. The current timestamp is NOT sent as safeTime
+ * timestamp.
Review Comment:
> The current timestamp is NOT sent as safeTime timestamp.
What does this comment mean and why is it important?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
