rpuch commented on code in PR #2756:
URL: https://github.com/apache/ignite-3/pull/2756#discussion_r1377112503
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManagementUtils.java:
##########
@@ -259,8 +259,8 @@ static int extractIndexIdFromPartitionBuildIndexKey(String
key) {
* @param localNode Local node.
* @param timestamp Timestamp of interest.
*/
- static boolean isLeaseExpire(ReplicaMeta primaryReplicaMeta, ClusterNode
localNode, HybridTimestamp timestamp) {
+ static boolean isPrimaryReplica(ReplicaMeta primaryReplicaMeta,
ClusterNode localNode, HybridTimestamp timestamp) {
Review Comment:
The method name is now inverted (isPrimaryReplica), but the code of the
method checks the opposite. It seems that it was forgotten that the logic of
the method (and the logic of the call) need to be inverted too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
