zstan commented on code in PR #2769:
URL: https://github.com/apache/ignite-3/pull/2769#discussion_r1378722193
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -125,7 +125,12 @@ public static String toString(ByteString b) {
/** LENGTH(VARBINARY|VARCHAR). */
public static int length(Object b) {
- return b instanceof ByteString ? octetLength((ByteString) b) :
charLength((String) b);
+ return b instanceof ByteString ? SqlFunctions.octetLength((ByteString)
b) : charLength((String) b);
+ }
+
+ /** OCTET_LENGTH(VARBINARY|VARCHAR). */
+ public static int octetLength(Object s) {
Review Comment:
+1 for overload
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
