nizhikov commented on code in PR #11040:
URL: https://github.com/apache/ignite/pull/11040#discussion_r1393984805
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteSnapshotManager.java:
##########
@@ -2737,9 +2769,44 @@ AbstractSnapshotFutureTask<?> registerSnapshotTask(
boolean withMetaStorage,
boolean dump,
SnapshotSender snpSndr
+ ) {
+ return registerSnapshotTask(snpName, snpPath, srcNodeId, requestId,
parts, withMetaStorage, dump, snpSndr, false);
+ }
+
+ /**
+ * @param snpName Unique snapshot name.
+ * @param snpPath Snapshot path.
+ * @param srcNodeId Node id which cause snapshot operation.
+ * @param requestId Snapshot operation request ID.
+ * @param parts Collection of pairs group and appropriate cache partition
to be snapshot.
+ * @param withMetaStorage {@code true} if all metastorage data must be
also included into snapshot.
+ * @param dump {@code true} if cache group dump must be created.
+ * @param snpSndr Factory which produces snapshot receiver instance.
+ * @param zip If {@code true} then zip the file.
+ * @return Snapshot operation task which should be registered on
checkpoint to run.
+ */
+ AbstractSnapshotFutureTask<?> registerSnapshotTask(
+ String snpName,
+ @Nullable String snpPath,
+ UUID srcNodeId,
+ UUID requestId,
+ Map<Integer, Set<Integer>> parts,
+ boolean withMetaStorage,
+ boolean dump,
+ SnapshotSender snpSndr,
+ boolean zip
Review Comment:
Let's move `zip` parameter one time up. Neat to `dump` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
