timoninmaxim commented on code in PR #11040: URL: https://github.com/apache/ignite/pull/11040#discussion_r1402395065
########## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/WriteOnlyZipFileIO.java: ########## @@ -0,0 +1,170 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.processors.cache.persistence.snapshot.dump; + +import java.io.BufferedOutputStream; +import java.io.File; +import java.io.IOException; +import java.io.OutputStream; +import java.nio.ByteBuffer; +import java.nio.MappedByteBuffer; +import java.nio.channels.Channels; +import java.nio.channels.WritableByteChannel; +import java.nio.file.Files; +import java.nio.file.Paths; +import java.util.zip.ZipEntry; +import java.util.zip.ZipOutputStream; +import org.apache.ignite.internal.processors.cache.persistence.file.AbstractFileIO; +import org.apache.ignite.internal.processors.cache.persistence.file.FileIO; +import org.apache.ignite.internal.util.typedef.internal.A; + +import static java.util.zip.Deflater.BEST_COMPRESSION; +import static org.apache.ignite.internal.processors.cache.persistence.file.FilePageStoreManager.ZIP_SUFFIX; + +/** + * {@link FileIO} that allows to write ZIP compressed file. + * It doesn't support reading or random access. + * It is not designed for writing concurrently from several threads. + * It uses 128KB buffer to temporarily keep data to improve throughput. + */ +public class WriteOnlyZipFileIO extends AbstractFileIO { + /** Buffer size */ + private static final int BUFFER_SIZE = 128 * 1024; + + /** */ + private final ZipOutputStream zos; + + /** */ + private final OutputStream bos; + + /** */ + private final WritableByteChannel ch; + + /** */ + private long pos; + + /** */ + public WriteOnlyZipFileIO(File file) throws IOException { + A.ensure(file.getName().endsWith(ZIP_SUFFIX), "File name should end with " + ZIP_SUFFIX); + + String entryName = file.getName().substring(0, file.getName().length() - ZIP_SUFFIX.length()); + + zos = new ZipOutputStream(new BufferedOutputStream(Files.newOutputStream(Paths.get(file.getPath())), BUFFER_SIZE)); + + zos.setLevel(BEST_COMPRESSION); + + zos.putNextEntry(new ZipEntry(entryName)); + + bos = new BufferedOutputStream(zos, BUFFER_SIZE); Review Comment: let's remove this buffered stream. One BOS before actual writing on disk is enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
