sashapolo commented on code in PR #3099:
URL: https://github.com/apache/ignite-3/pull/3099#discussion_r1467346622


##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManagementUtils.java:
##########
@@ -263,4 +265,31 @@ static boolean isPrimaryReplica(ReplicaMeta 
primaryReplicaMeta, ClusterNode loca
         return localNode.id().equals(primaryReplicaMeta.getLeaseholderId())
                 && timestamp.compareTo(primaryReplicaMeta.getExpirationTime()) 
< 0;
     }
+
+
+    /**
+     * Returns the catalog version in which the existing index created.
+     *
+     * <p>NOTE: Can be used outside of catalog/metastore events.</p>

Review Comment:
   I'm not sure that leaving notes for yourself in documentation is a good 
idea. It is also inconsistent, because all other methods don't specify that 
they must be called in some event threads



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to