rpuch commented on code in PR #3103:
URL: https://github.com/apache/ignite-3/pull/3103#discussion_r1469953327
##########
modules/network/src/main/java/org/apache/ignite/network/DefaultMessagingService.java:
##########
@@ -310,7 +311,14 @@ private CompletableFuture<Void> sendViaNetwork(
}
return connectionManager.channel(consistentId, type, addr)
- .thenComposeToCompletable(sender -> sender.send(new
OutNetworkObject(message, descriptors)));
+ .thenComposeToCompletable(sender -> sender.send(
+ new OutNetworkObject(message, descriptors),
+ () -> triggerChannelCreation(consistentId, type, addr)
+ ));
+ }
+
+ private OrderingFuture<NettySender> triggerChannelCreation(@Nullable
String consistentId, ChannelType type, InetSocketAddress addr) {
Review Comment:
To make it clear why `connectionManager.channel()` is used, to make the
intention obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
