vldpyatkov commented on code in PR #3069:
URL: https://github.com/apache/ignite-3/pull/3069#discussion_r1473945853
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##########
@@ -1403,7 +1405,25 @@ private Publisher<BinaryRow> scan(
columnsToInclude,
implicit
),
- (commit, fut) -> postEnlist(fut, commit, actualTx, implicit &&
!commit)
+ (intentionallyClose, fut) -> {
+ CompletableFuture<Void> opFut;
+
+ if (implicit) {
+ opFut = fut.thenApply(cursorId -> null);
Review Comment:
Because the implicit transaction has to close the cursor in the post-enlist
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]