ascherbakoff commented on code in PR #3148: URL: https://github.com/apache/ignite-3/pull/3148#discussion_r1477845886
########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/action/RowOpType.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.table.distributed.replicator.action; + + +/** + * Row operation type. + */ +public enum RowOpType { Review Comment: Enum is not required for two state op type, can just use a single bit. ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replication/request/ReadWriteMultiRowReplicaRequest.java: ########## @@ -31,4 +33,12 @@ public interface ReadWriteMultiRowReplicaRequest extends MultipleRowReplicaReque * @return {@code True} to disable the delayed ack optimization. */ boolean skipDelayedAck(); + + /** + * Optional operation types (one for every tuple in {@link #binaryTuples()}. + * See {@link RowOpType}. + * + * @return A byte for every tuple in {@link #binaryTuples()} indicating an operation type for that row. + */ + byte @Nullable [] operationTypes(); Review Comment: Maybe use a bitset here ? A corresponding bit is set to 1 for removal, 0 otherwise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
