ibessonov commented on code in PR #3196:
URL: https://github.com/apache/ignite-3/pull/3196#discussion_r1484397075
##########
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/scalecube/ItScaleCubeNetworkMessagingTest.java:
##########
@@ -996,10 +996,17 @@ private CompletableFuture<Void>
sendMessage(ClusterService sender, ClusterServic
return send(messageFactory.testMessage().build(), sender, receiver);
}
- private static OutgoingAcknowledgementSilencer dropAcksFrom(ClusterService
clusterService) throws InterruptedException {
+ private static OutgoingAcknowledgementSilencer
dropAcksWhenDefaultChannelOpens(ClusterService clusterService)
+ throws InterruptedException {
DefaultMessagingService messagingService = (DefaultMessagingService)
clusterService.messagingService();
- return
OutgoingAcknowledgementSilencer.installOn(messagingService.connectionManager().channels().values());
+ ConnectionManager connectionManager =
messagingService.connectionManager();
+ waitForCondition(
Review Comment:
please assert that this method returns true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
