AMashenkov commented on code in PR #3187:
URL: https://github.com/apache/ignite-3/pull/3187#discussion_r1494435502
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/QuerySplitter.java:
##########
@@ -188,12 +191,13 @@ public IgniteRel visit(IgniteTableScan rel) {
IgniteTable table = rel.getTable().unwrap(IgniteTable.class);
assert table != null;
+ long sourceId = idGenerator.nextId();
if (curr.seenRelations.add(table.id())) {
- curr.tables.add(table);
+ curr.tables.put(sourceId, table);
Review Comment:
If it was done intentionally, then what is the purpose of using
Long2ObjectMap?
Adding cost O(n), `get` costs also O(n). It is worst alternative to a
hash-based map and a list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
