sk0x50 commented on code in PR #3248:
URL: https://github.com/apache/ignite-3/pull/3248#discussion_r1499129316
##########
modules/failure-handler/src/test/java/org/apache/ignite/internal/failure/FailureProcessorTest.java:
##########
@@ -49,4 +53,21 @@ void testFailureProcessing() {
failureProcessor.stop();
}
}
+
+ @Test
+ void testIgnoredFailureTypes() {
+ FailureHandler handler = new NoOpFailureHandler();
+
+ FailureProcessor failureProcessor = new FailureProcessor("node_name",
handler);
+
+ assertThat(failureProcessor.start(), willSucceedFast());
+
+ try {
+ assertThat(failureProcessor.process(new
FailureContext(SYSTEM_WORKER_BLOCKED, null)), is(false));
+
+ assertThat(failureProcessor.process(new
FailureContext(SYSTEM_CRITICAL_OPERATION_TIMEOUT, null)), is(false));
+ } finally {
+ failureProcessor.stop();
+ }
Review Comment:
Honestly, it is not obvious from the javadoc that it is allowed to call
`stop` on non started component. Anyway. I fixed it in the way you proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
