tkalkirill commented on code in PR #3299:
URL: https://github.com/apache/ignite-3/pull/3299#discussion_r1504358441
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -3814,4 +3845,22 @@ private HybridTimestamp
indexStartBuildingActivationTs(BuildIndexReplicaRequest
return hybridTimestamp(catalog.time());
}
+
+ private int schemaVersionByTs(HybridTimestamp ts) {
+ int activeCatalogVersion =
catalogService.activeCatalogVersion(ts.longValue());
+
+ CatalogTableDescriptor table = catalogService.table(tableId(),
activeCatalogVersion);
+
+ assert table != null : "tableId=" + tableId() + ", catalogVersion=" +
activeCatalogVersion;
+
+ return table.tableVersion();
+ }
+
+ private static @Nullable BinaryRow binaryRow(@Nullable TimedBinaryRow
timedBinaryRow) {
+ return timedBinaryRow == null ? null : timedBinaryRow.binaryRow();
+ }
+
+ private @Nullable BinaryRow upgrage(@Nullable BinaryRow source, int
targetSchemaVersion) {
+ return source == null ? null : new BinaryRowUpgrader(schemaRegistry,
targetSchemaVersion).upgrade(source);
Review Comment:
We discussed it in person, let's leave it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
