AMashenkov commented on code in PR #3309:
URL: https://github.com/apache/ignite-3/pull/3309#discussion_r1506007406
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/ColocatedSortAggregatePlannerTest.java:
##########
@@ -293,47 +295,17 @@ public void noSortAppendingWithCorrectCollation() throws
Exception {
*/
@Test
public void emptyCollationPassThroughLimit() throws Exception {
- assertPlan(TestCase.CASE_17,
- hasChildThat(isInstanceOf(IgniteCorrelatedNestedLoopJoin.class)
- .and(input(1,
isInstanceOf(IgniteColocatedSortAggregate.class)
- .and(input(isInstanceOf(IgniteLimit.class)
-
.and(input(isInstanceOf(IgniteSort.class)
-
.and(input(isTableScan("TEST")))
- ))
- ))
- ))
- ),
- disableRules
- );
+ RuntimeException e = assertThrows(RuntimeException.class,
+ () -> assertPlan(TestCase.CASE_17,
isInstanceOf(IgniteRel.class), disableRules));
+ assertThat(e.getMessage(), containsString("There are not enough rules
to produce a node with desired properties"));
Review Comment:
Maybe, it would be better to disable tests instead of rewriting their code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
