rpuch commented on code in PR #3300:
URL: https://github.com/apache/ignite-3/pull/3300#discussion_r1507050555


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -351,11 +353,16 @@ private PartialNode startPartialNode(
         LongSupplier partitionIdleSafeTimePropagationPeriodMsSupplier
                 = () -> 
TestIgnitionManager.DEFAULT_PARTITION_IDLE_SYNC_TIME_INTERVAL_MS;
 
-        var replicaService = new ReplicaService(
+        MessagingService messagingServiceReturningToStorageOperationsPool = 
new JumpToExecutorByConsistentIdAfterSend(
                 clusterSvc.messagingService(),
-                hybridClock,
                 name,
-                threadPools.partitionOperationsExecutor()
+                message -> threadPoolsManager.partitionOperationsExecutor()

Review Comment:
   This pool is used for processing operations on partitions, hence the name. 
The wrapper around MessagingService that is constructed here is also used by 
the components that deal with processing operations on partitions, so it 
returns the control to the same partition-operations pool. But there are parts 
of the system that don't use it; they might use another wrapper around 
MessagingService to return to that another pool (maybe operations with the 
Metastorage should work like this). So, it's not the system-wide pool, its 
usage is still restricted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to