Cyrill commented on code in PR #3371: URL: https://github.com/apache/ignite-3/pull/3371#discussion_r1520178331
########## modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TransactionInflights.java: ########## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.tx.impl; + +import static java.util.concurrent.CompletableFuture.failedFuture; +import static java.util.stream.Collectors.toSet; +import static org.apache.ignite.internal.lang.IgniteStringFormatter.format; +import static org.apache.ignite.internal.tx.TxState.ABORTED; +import static org.apache.ignite.internal.util.CompletableFutures.nullCompletedFuture; +import static org.apache.ignite.lang.ErrorGroups.Transactions.TX_PRIMARY_REPLICA_EXPIRED_ERR; + +import java.util.Collection; +import java.util.Map; +import java.util.Map.Entry; +import java.util.UUID; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ConcurrentHashMap; +import java.util.function.Function; +import org.apache.ignite.internal.lang.IgniteBiTuple; +import org.apache.ignite.internal.placementdriver.PlacementDriver; +import org.apache.ignite.internal.placementdriver.ReplicaMeta; +import org.apache.ignite.internal.replicator.TablePartitionId; +import org.apache.ignite.internal.tx.MismatchingTransactionOutcomeException; +import org.apache.ignite.internal.tx.TransactionResult; +import org.apache.ignite.network.ClusterNode; +import org.jetbrains.annotations.Nullable; + +/** + * Contains counters for in-flight requests of the transactions. Read-write transactions can't finish when some requests are in-flight. + * Read-only transactions can't be included into {@link org.apache.ignite.internal.tx.message.FinishedTransactionsBatchMessage} when + * some requests are in-flight. + */ +public class TransactionInflights { + /** Hint for maximum concurrent txns. */ + private static final int MAX_CONCURRENT_TXNS = 1024; + + /** Txn contexts. */ + private final ConcurrentHashMap<UUID, TxContext> txCtxMap = new ConcurrentHashMap<>(MAX_CONCURRENT_TXNS); Review Comment: Before this change the collection of txns in FinishedReadOnlyTransactionTracker was ordered FIFO, in other words finished txns didn't wait much for their turn. Now we have an unordered collection. This is not an action item, rather a topic to discuss -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
